[RHOAIENG-11333] Modify status labels for runs and executions

[jpuzz0]

https://issues.redhat.com/browse/RHOAIENG-11333

Description

Updated icons/labels for statuses based on this figma referenced in the JIRA issue: https://www.figma.com/design/Beh8E4dQQ5hq0Kzd9qLaCZ/Pipelines-v2-enhancements?node-id=582-15436

How Has This Been Tested?

Verify all pages referenced in the figma (or this doc, which is just another way of consuming the same information) match.

Test Impact

Had to update some tests to account for icon changes. Otherwise, these are non-functional changes so shouldn't effect cypress tests.

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[codecov]

Codecov Report

Attention: Patch coverage is 47.05882% with 45 lines in your changes missing coverage. Please review.

Project coverage is 85.02%. Comparing base (96e06a2) to head (5c962f8).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../global/experiments/executions/ExecutionStatus.tsx	40.00%	12 Missing ⚠️
...concepts/topology/customNodes/StandardTaskNode.tsx	57.69%	11 Missing ⚠️
...src/concepts/topology/PipelineDefaultTaskGroup.tsx	0.00%	10 Missing ⚠️
frontend/src/concepts/topology/NodeStatusIcon.tsx	0.00%	9 Missing ⚠️
...concepts/topology/customNodes/ArtifactTaskNode.tsx	0.00%	2 Missing ⚠️
frontend/src/concepts/pipelines/content/utils.tsx	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3347      +/-   ##
==========================================
+ Coverage   85.01%   85.02%   +0.01%     
==========================================
  Files        1327     1327              
  Lines       29770    29810      +40     
  Branches     8149     8159      +10     
==========================================
+ Hits        25308    25345      +37     
- Misses       4462     4465       +3     

Files with missing lines	Coverage Δ
...pelines/content/compareRuns/CompareRunTableRow.tsx	100.00% <ø> (ø)
...ipelines/content/tables/experiment/renderUtils.tsx	100.00% <ø> (ø)
...content/tables/pipelineRun/PipelineRunTableRow.tsx	94.11% <ø> (ø)
.../concepts/pipelines/content/tables/renderUtils.tsx	77.94% <100.00%> (+2.94%)	⬆️
frontend/src/concepts/pipelines/kfTypes.ts	100.00% <100.00%> (ø)
...obal/experiments/executions/ExecutionsTableRow.tsx	100.00% <ø> (ø)
...xperiments/executions/details/ExecutionDetails.tsx	85.00% <ø> (ø)
frontend/src/concepts/pipelines/content/utils.tsx	81.25% <80.00%> (+0.60%)	⬆️
...concepts/topology/customNodes/ArtifactTaskNode.tsx	80.76% <0.00%> (ø)
frontend/src/concepts/topology/NodeStatusIcon.tsx	2.04% <0.00%> (-0.35%)	⬇️
... and 3 more

... and 8 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e06a2...5c962f8. Read the comment docs.

[Gkrumbach07]

group nodes need their loading icon updated
the canceled icon is not the new one for group nodes

seems like group nodes were missed in general

[jpuzz0]

group nodes need their loading icon updated the canceled icon is not the new one for group nodes

seems like group nodes were missed in general

@Gkrumbach07
I can update the "Running" statuses to show the expected light blue/in progress icon, however the Canceled state's icon is not overridable after discussing with @jeff-phillips-18. I've opened an issue to Topology for this to be addressed: patternfly/react-topology#240.

How would you like to proceed with this issue in the meantime?

[jpuzz0]

group nodes need their loading icon updated the canceled icon is not the new one for group nodes
seems like group nodes were missed in general

@Gkrumbach07 I can update the "Running" statuses to show the expected light blue/in progress icon, however the Canceled state's icon is not overridable after discussing with @jeff-phillips-18. I've opened an issue to Topology for this to be addressed: patternfly/react-topology#240.

How would you like to proceed with this issue in the meantime?

I've added a comment and a new follow-up story to address the custom icon for Canceled status group nodes. Our team's jira issue is here; https://issues.redhat.com/browse/RHOAIENG-14822 and the PF issue is here; patternfly/react-topology#240.

[DaoDaoNoCode]

@jpuzz0
All lgtm, just have one request that's not related to this PR but I hope to see if it's possible to make changes here.

In #3140, I changed the icon for the artifact nodes based on the metrics type. However, looks like I only changed the icon when it's not hovered. If the node is hovered, the icon will be incorrect.

e.g. In the following 2 screenshot, the icon should be both monitoring icon, however, the second one is a list icon

The reason is I only updated https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/concepts/topology/customNodes/ArtifactTaskNode.tsx#L89, but didn't update https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/concepts/topology/customNodes/ArtifactTaskNode.tsx#L132 and https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/concepts/topology/customNodes/ArtifactTaskNode.tsx#L155 to use the isMetricsArtifactType function, which causes the inconsistency.

Could you update that in this PR because it's also about the icon/status? Thanks!

[jpuzz0]

@jpuzz0 All lgtm, just have one request that's not related to this PR but I hope to see if it's possible to make changes here.

In #3140, I changed the icon for the artifact nodes based on the metrics type. However, looks like I only changed the icon when it's not hovered. If the node is hovered, the icon will be incorrect.

e.g. In the following 2 screenshot, the icon should be both monitoring icon, however, the second one is a list icon

The reason is I only updated https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/concepts/topology/customNodes/ArtifactTaskNode.tsx#L89, but didn't update https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/concepts/topology/customNodes/ArtifactTaskNode.tsx#L132 and https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/concepts/topology/customNodes/ArtifactTaskNode.tsx#L155 to use the isMetricsArtifactType function, which causes the inconsistency.

Could you update that in this PR because it's also about the icon/status? Thanks!

@DaoDaoNoCode I've updated this.

[DaoDaoNoCode]

Thanks, LGTM!
/lgtm

[Gkrumbach07]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [Gkrumbach07]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment