[feat] tools-v2: add update leader-schedule[-all] #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools-v2/pkg/cli/command/curvebs/update/leader_schedule_all/leader_schedule_all.go
Outdated
Show resolved
Hide resolved
tools-v2/pkg/cli/command/curvebs/update/leader_schedule/leader_schedule.go
Outdated
Show resolved
Hide resolved
tools-v2/pkg/cli/command/curvebs/update/leader_schedule_all/leader_schedule_all.go
Outdated
Show resolved
Hide resolved
montaguelhz
force-pushed
the
schedule
branch
2 times, most recently
from
b32dcd8 to
a97d83b
Compare
|
cicheck |
|
@Cyber-SiKu please take a look this pr, thx. |
He must be enjoying the Dragon Boat Festival. Happy Dragon Boat Festival！ |
hahah, just remind him to attention it~ |
|
@montaguelhz u can take a look issue #2352, u can implement it by the same way as this pr~(related sub-commands have implemented now) |
ok |
Cyber-SiKu
reviewed
Jun 25, 2023
tools-v2/pkg/cli/command/curvebs/update/leader_schedule/leader_schedule.go
Outdated
Show resolved
Hide resolved
Cyber-SiKu
reviewed
Jun 25, 2023
tools-v2/pkg/cli/command/curvebs/update/leader_schedule/leader_schedule.go
Outdated
Show resolved
Hide resolved
|
cicheck |
1 similar comment
|
cicheck |
Cyber-SiKu
reviewed
Jun 25, 2023
| return err.ToError() | ||
| } | ||
| out := make(map[string]string) | ||
| if response, ok := result.(*schedule.RapidLeaderScheduleResponse); ok { |
Comment on lines
145
to
151
| if response.GetStatusCode() != 0 { | ||
| out[cobrautil.ROW_RESULT] = cobrautil.ROW_VALUE_FAILED | ||
| out[cobrautil.ROW_REASON] = statuscode.ScheduleStatusCode_name[*response.StatusCode] | ||
| } else { | ||
| out[cobrautil.ROW_RESULT] = cobrautil.ROW_VALUE_SUCCESS | ||
| out[cobrautil.ROW_REASON] = cobrautil.ROW_VALUE_NULL | ||
| } |
There was a problem hiding this comment.
This can be handled by adding ErrBsRapidLeaderSchedule.
Suggested change
| if response.GetStatusCode() != 0 { | |
| out[cobrautil.ROW_RESULT] = cobrautil.ROW_VALUE_FAILED | |
| out[cobrautil.ROW_REASON] = statuscode.ScheduleStatusCode_name[*response.StatusCode] | |
| } else { | |
| out[cobrautil.ROW_RESULT] = cobrautil.ROW_VALUE_SUCCESS | |
| out[cobrautil.ROW_REASON] = cobrautil.ROW_VALUE_NULL | |
| } | |
| err = cmderr.ErrBsRapidLeaderSchedule(response.GetStatusCode()) | |
| if err.TypeCode() != cmderr.CODE_SUCCESS { | |
| out[cobrautil.ROW_RESULT] = cobrautil.ROW_VALUE_FAILED | |
| } else { | |
| out[cobrautil.ROW_RESULT] = cobrautil.ROW_VALUE_SUCCESS | |
| } | |
| out[cobrautil.ROW_REASON] = err.Message |
| lCmd.TableNew.Append(res) | ||
|
|
||
| lCmd.Result = out | ||
| lCmd.Error = cmderror.ErrSuccess() |
There was a problem hiding this comment.
Suggested change
| lCmd.Error = cmderror.ErrSuccess() | |
| lCmd.Error = err |
Signed-off-by: montaguelhz <[email protected]>
|
cicheck |
|
cicheck |
1 similar comment
|
cicheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2359
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
curve bs update leader-schedule --logicalpoolid 1
curve bs update leader-schedule-all
+---------+--------+
| RESULT | REASON |
+---------+--------+
| success | null |
+---------+--------+
+--------+--------------------+
| RESULT | REASON |
+--------+--------------------+
| failed | InvalidLogicalPool |
+--------+--------------------+
Side effects(Breaking backward compatibility? Performance regression?):
Check List