[feature]add fmtlib(#2291) #2367
Conversation
Signed-off-by: tangruilin <[email protected]>
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| "Move-Item -Path support/bazel/WORKSPACE.bazel -Destination WORKSPACE.bazel", | ||
| ], | ||
| ) | ||
|
|
||
| bind( | ||
| name = "braft", | ||
| actual = "@com_github_baidu_braft//:braft", |
There was a problem hiding this comment.
with the code review
The code looks good. There is no obvious bug risk and the patch_cmds/patch_cmds_win are well defined. However, there are a few improvements that can be made.
First, it would be better to use variables instead of hardcoded paths in the patch_cmds and patch_cmds_win. This would make the code more flexible, as different paths could be used in different environments.
Second, the patch_cmds and patch_cmds_win should be moved to a separate file and imported into this file, rather than having all of the commands listed in the same file. This will help keep the code more organized and easier to maintain.
Finally, some comments should be added to the code to explain what each line does and why it is necessary. This will help future developers understand the code more easily.
|
/recheck |
|
recheck |
|
@wuhongsong please look it. Thanks |
|
are there someone review this PR |
|
Can you use BTW. give a example to how to print a |
| @@ -37,6 +37,25 @@ git_repository( | |||
| commit = "d12de388c97998f5ccd5cb97ed0da728815ef438", | |||
| ) | |||
|
|
|||
| git_repository( | |||
| name = "fmt", | |||
| branch = "master", | |||
There was a problem hiding this comment.
Use a stable version? For example tag: 9.1.0.
agree! You can modify an old code as an example, or modify some unit tests. |
|
cicheck |
1 similar comment
|
cicheck |
ok, i will do it these day |
|
@Tangruilin Will you continue to follow up this PR? |
|
@Tangruilin Will you continue to follow up this PR? |
|
cicheck |
|
cicheck |
| name = "fmt", | ||
| branch = "master", | ||
| remote = "https://github.com/fmtlib/fmt", | ||
| commit = "bce8d4ed087a0560492426f9f5be2713804daded" |
|
continue in 2635 |
What problem does this PR solve?
Issue Number: #2291
Problem Summary:
What is changed and how it works?
What's Changed:
add libfmt fot glog
How it Works:
now we can use
fmt::print("{}", 4)to format log. Details can look issue#2291Side effects(Breaking backward compatibility? Performance regression?):
Check List