Add imagelayout validator and ImageLayoutFile const #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
stevvooe
reviewed
Jan 25, 2017
schema/schema.go
Outdated
| @@ -26,6 +26,7 @@ const ( | |||
| MediaTypeManifest Validator = v1.MediaTypeImageManifest | |||
| MediaTypeManifestList Validator = v1.MediaTypeImageManifestList | |||
| MediaTypeImageConfig Validator = v1.MediaTypeImageConfig | |||
| TypeImageLayout Validator = v1.ImageLayoutFile | |||
There was a problem hiding this comment.
O, this is weird. All of these should start with Validator.
There was a problem hiding this comment.
All of these should start with Validator.
Or we could drop them and use a map: #403.
There was a problem hiding this comment.
#403 is never going to land. This effectively uses a map internally anyways. See my example.
Added a commit to address this. |
coolljt0725
force-pushed
the
validate_layout
branch
2 times, most recently
from
0ab3d08 to
471750d
Compare
|
You have to modify other test files. |
|
LGTM Please fix the build. ;) |
Signed-off-by: Lei Jitang <[email protected]>
Add image layout validator so the image tool or other tools can use the image-spec to validate the oci image. Signed-off-by: Lei Jitang <[email protected]>
Signed-off-by: Lei Jitang <[email protected]>
coolljt0725
force-pushed
the
validate_layout
branch
from
471750d to
88d41e8
Compare
|
LGTM |
1 similar comment
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had added image layout schema, but didn't add image layout validator.
Add imagelayout validator and ImageLayoutFile const, so image tool and other
tools can use image -spec to validate the layout of the oci image.