Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added next-hop-network-instance under mpls egress config. #1219

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

vishnureddybadveli
Copy link

@vishnureddybadveli vishnureddybadveli commented Nov 9, 2024

Change Scope
(M) release/models/mpls/openconfig-mpls-static.yang

Packet flow:
An IP in MPLS packet enters the device from the backbone/provider network
The MPLS packet enters from the “DEFAULT” network-instance
The inner IP packet is a customer packet
Goal is to decap/pop a provider MPLS label and lookup on the inner IP packet in the customer’s VRF

Intent is to do a lookup for the nexthop (to determine egress interface and rewrite) in a vrf that is different from the ingress interface's VRF.
For example: in some vpc use case ingress interface is in the default VRF as it's facing the providers network and the egress interface is in a customer specific VRF.

Currently model does not support mpls route to a specific next hop network instance, we are adding support for network instance in which to resolve the next hop.

/network-instances/network-instance/mpls/lsps/static-lsps/static-lsp/egress/lsp-next-hops/lsp-next-hop/config/next-hop-network-instance
/network-instances/network-instance/mpls/lsps/static-lsps/static-lsp/egress/lsp-next-hops/lsp-next-hop/state/next-hop-network-instance

Platform Implementations
Arista:
CLI configuration:

mpls static top-label <label> <nexthop-ip> vrf <vrf> pop payload-type ipv4/6
mpls static top-label <label> <nexthop-ip> vrf <vrf> pop 

Not adding any OC to cover the payload-type because this is not needed operationally and the vendor is expected to support any payload type without statically configuring it.

Juniper:
https://www.juniper.net/documentation/us/en/software/junos/cli-reference/topics/ref/statement/vrf-table-label-edit-routing-instances-vp.html

@vishnureddybadveli vishnureddybadveli requested a review from a team as a code owner November 9, 2024 02:29
@dplore
Copy link
Member

dplore commented Nov 12, 2024

/gcbrun

@OpenConfigBot
Copy link

OpenConfigBot commented Nov 12, 2024

No major YANG version changes in commit 1db5287

@dplore dplore self-assigned this Nov 12, 2024
Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description to include why the change is being added and update the yang model version numbers.

@AnnamalaiRajeev
Copy link
Contributor

Hello Vishnu as discussed on the operators board. Please include vendor config and usecase. Limit augment to only egress LSP. thx

@vishnureddybadveli
Copy link
Author

Hello Vishnu as discussed on the operators board. Please include vendor config and usecase. Limit augment to only egress LSP. thx

Rajeev, description is updated with only egress use case and one vendor config. We are looking for a second vendor that can implement similar functionality. Once we find second vendor I will work on the augment part.

Created a new grouping static-lsp-nexthops-egress to restrict leaf only to egress.
Removed next-hop-network-instance from common.
@dplore
Copy link
Member

dplore commented Jan 21, 2025

@vishnureddybadveli , can you provide a config example from JunOS? The referenced documentation sort of sounds like it matches this use case, but it's not clear. An example config snippet would help. Or alternatively, you could reference a different implementation if that is easier to provide an example.

@dplore
Copy link
Member

dplore commented Jan 21, 2025

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

8 participants