Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kind to 1.24.0 and node to 1.31.0 #570

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Update kind to 1.24.0 and node to 1.31.0 #570

merged 4 commits into from
Dec 18, 2024

Conversation

marcushines
Copy link
Contributor

also updates kube apis to 1.31

also updates kube apis to 1.31
@marcushines marcushines requested a review from DanG100 November 4, 2024 21:37
@DanG100
Copy link
Collaborator

DanG100 commented Nov 4, 2024

It doesn't look you changed in the kindest/node image anywhere? https://github.com/openconfig/kne/blob/main/deploy/kne/kind-bridge.yaml#L10

@marcushines
Copy link
Contributor Author

It doesn't look you changed in the kindest/node image anywhere? https://github.com/openconfig/kne/blob/main/deploy/kne/kind-bridge.yaml#L10

fixed

@DanG100
Copy link
Collaborator

DanG100 commented Nov 5, 2024

lgtm assuming you can fix presubmit

@marcushines
Copy link
Contributor Author

/gcbrun

@marcushines
Copy link
Contributor Author

/gcbrun

@@ -1,6 +1,6 @@
module github.com/openconfig/kne

go 1.21
go 1.22.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are Go 1.21 version references in:

cloudbuild/external.pkr.hcl
cloudbuild/internal.pkr.hcl
.github/workflows/go.yml
docs/setup.md
x/wire/forward/Dockerfile

We should use the same go version in all of these (and use 1.23.2?)

@marcushines marcushines merged commit 3315c2f into main Dec 18, 2024
8 of 10 checks passed
@marcushines marcushines deleted the hines branch December 18, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants