Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credential provider option to kubeadm #533

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Add credential provider option to kubeadm #533

merged 3 commits into from
Apr 25, 2024

Conversation

alexmasi
Copy link
Contributor

@alexmasi alexmasi commented Apr 25, 2024

This allows passing in a config file to define a credential provider for the kubelet. This enables automatic auth refresh for pulling images from private gcp regs on a GCE VM.

@coveralls
Copy link

coveralls commented Apr 25, 2024

Pull Request Test Coverage Report for Build 8840466257

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 27 of 47 (57.45%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 65.113%

Changes Missing Coverage Covered Lines Changed/Added Lines %
deploy/deploy.go 1 4 25.0%
cluster/kubeadm/kubeadm.go 24 32 75.0%
controller/server/main.go 2 11 18.18%
Files with Coverage Reduction New Missed Lines %
controller/server/main.go 1 37.67%
Totals Coverage Status
Change from base Build 8807012865: -0.05%
Covered Lines: 4625
Relevant Lines: 7103

💛 - Coveralls

@alexmasi alexmasi marked this pull request as ready for review April 25, 2024 23:04
@alexmasi alexmasi merged commit a682615 into main Apr 25, 2024
11 checks passed
@alexmasi alexmasi deleted the kadm branch April 25, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants