Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine kne node for Alpine Virtual Switch #470

Merged
merged 20 commits into from
Dec 13, 2023

Conversation

sonikajindal
Copy link
Contributor

No description provided.

topo/node/alpine/alpine.go Outdated Show resolved Hide resolved
topo/node/alpine/alpine.go Outdated Show resolved Hide resolved
topo/node/alpine/alpine.go Outdated Show resolved Hide resolved
proto/alpine.proto Outdated Show resolved Hide resolved
proto/topo.proto Outdated Show resolved Hide resolved
topo/node/alpine/alpine.go Show resolved Hide resolved
topo/node/alpine/alpine.go Outdated Show resolved Hide resolved
topo/node/alpine/alpine_test.go Show resolved Hide resolved
Copy link
Contributor

@alexmasi alexmasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really close!

Also there is an issue the linter is complaining about

topo/node/alpine/alpine.go Show resolved Hide resolved
topo/node/alpine/alpine.go Outdated Show resolved Hide resolved
topo/node/alpine/alpine.go Outdated Show resolved Hide resolved
topo/node/alpine/alpine.go Show resolved Hide resolved
topo/node/alpine/alpine.go Show resolved Hide resolved
topo/node/alpine/alpine.go Show resolved Hide resolved
examples/alpine/alpine.pb.txt Outdated Show resolved Hide resolved
examples/alpine/alpine.pb.txt Show resolved Hide resolved
@alexmasi
Copy link
Contributor

/gcbrun

@sonikajindal
Copy link
Contributor Author

/gcbrun

@sonikajindal
Copy link
Contributor Author

/gcbrun

@alexmasi
Copy link
Contributor

/gcbrun

@alexmasi alexmasi merged commit 47b283f into openconfig:main Dec 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants