Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After deleting a topology, remove it from the map. #461

Merged
merged 1 commit into from
Nov 16, 2023
Merged

After deleting a topology, remove it from the map. #461

merged 1 commit into from
Nov 16, 2023

Conversation

bormanp
Copy link
Collaborator

@bormanp bormanp commented Nov 16, 2023

DeleteTopology was not removing the topology from s.topos preventing the topology from being re-deployed after deleting the existing deployment.

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 6893753593

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 65.67%
Changes Missing Coverage Covered Lines Changed/Added Lines %
controller/server/main.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
controller/server/main.go 1 38.64%
Totals Coverage Status
Change from base Build 6883575364: -0.01%
Covered Lines: 4065
Relevant Lines: 6190
💛 - Coveralls

@bormanp
Copy link
Collaborator Author

bormanp commented Nov 16, 2023

/gcbrun

@bormanp bormanp requested a review from alexmasi November 16, 2023 16:43
@alexmasi alexmasi merged commit 4fe7a0f into main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmasi alexmasi alexmasi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bormanp @alexmasi