Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeepCopy for reconcile operations, improve RIB locking. #226

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add DeepCopy for reconcile operations, improve RIB locking. #226

merged 1 commit into from
Dec 13, 2023

Conversation

robshakir
Copy link
Contributor 

* (M) rib/reconciler/reconcile(_test)?.go
   - Add a DeepCopy method for ReconcileOps and Ops so that users can
     duplicate these collections of operations more easily.
 * (M) rib/rib.go
   - Ensure that we hold the per NI RIB mutex as well as the overall RIB
     mutex when copying.

@robshakir
Add DeepCopy for reconcile operations, improve RIB locking.
f9c7af2 
 * (M) rib/reconciler/reconcile(_test)?.go
   - Add a DeepCopy method for ReconcileOps and Ops so that users can
     duplicate these collections of operations more easily.
 * (M) rib/rib.go
   - Ensure that we hold the per NI RIB mutex as well as the overall RIB
     mutex when copying.
@robshakir robshakir assigned robshakir and unassigned akrentsel Dec 13, 2023
@robshakir robshakir merged commit e2c2125 into main Dec 13, 2023
7 checks passed
@robshakir robshakir deleted the deepcopy branch December 13, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrentsel akrentsel akrentsel approved these changes

@alshabib alshabib Awaiting requested review from alshabib

Assignees

@robshakir robshakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robshakir @akrentsel