Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acctz-3.1 fix start/stop accounting check #3709

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dipchauh
Copy link
Contributor

Added check to skip start/stop accounting records using session_status instead of checking for repeated task_ids. task_id is an optional field in the proto & its functionality can differ per vendor.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@OpenConfigBot
Copy link

Pull Request Functional Test Report for #3709 / bfee20a

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
ACCTZ-3.1: Record Subscribe Non-gRPC
Cisco 8000E status
ACCTZ-3.1: Record Subscribe Non-gRPC
Cisco XRd status
ACCTZ-3.1: Record Subscribe Non-gRPC
Juniper ncPTX status
ACCTZ-3.1: Record Subscribe Non-gRPC
Nokia SR Linux status
ACCTZ-3.1: Record Subscribe Non-gRPC
Openconfig Lemming status
ACCTZ-3.1: Record Subscribe Non-gRPC

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
ACCTZ-3.1: Record Subscribe Non-gRPC
Cisco 8808 status
ACCTZ-3.1: Record Subscribe Non-gRPC
Juniper PTX10008 status
ACCTZ-3.1: Record Subscribe Non-gRPC
Nokia 7250 IXR-10e status
ACCTZ-3.1: Record Subscribe Non-gRPC

Help

@dipchauh dipchauh marked this pull request as ready for review January 22, 2025 19:52
@dipchauh dipchauh requested a review from a team as a code owner January 22, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants