Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT-1.28: Invert the verification for removal testcases #3694

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yini101
Copy link
Contributor

@yini101 yini101 commented Jan 15, 2025

The testcase was waiting for the prefix to exist, but checking for it to NOT exist. It would fail when the prefix hasn't been removed by the time Await() function gets called. The fix is to invert the check and wait for the prefix removal.

The testcase was waiting for the prefix to exist, but
checking for it to NOT exist. It would fail when the
prefix hasn't been removed by the time Await() function
gets called. The fix is to invert the check and wait for
the prefix removal.
@yini101 yini101 requested a review from a team as a code owner January 15, 2025 23:18
@OpenConfigBot
Copy link

Pull Request Functional Test Report for #3694 / 9f7e05c

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-1.28: BGP to IS-IS redistribution
Cisco 8000E status
RT-1.28: BGP to IS-IS redistribution
Cisco XRd status
RT-1.28: BGP to IS-IS redistribution
Juniper ncPTX status
RT-1.28: BGP to IS-IS redistribution
Nokia SR Linux status
RT-1.28: BGP to IS-IS redistribution
Openconfig Lemming status
RT-1.28: BGP to IS-IS redistribution

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-1.28: BGP to IS-IS redistribution
Cisco 8808 status
RT-1.28: BGP to IS-IS redistribution
Juniper PTX10008 status
RT-1.28: BGP to IS-IS redistribution
Nokia 7250 IXR-10e status
RT-1.28: BGP to IS-IS redistribution

Help

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12798748474

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12784502510: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants