-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a new test under compliance #3315
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #3315 / e96cce1Virtual Devices
Hardware Devices
|
81aae77
to
ac59fa6
Compare
Pull Request Test Coverage Report for Build 10210215200Details
💛 - Coveralls |
9b8c3f1
to
115305d
Compare
65e1f87
to
bb736d9
Compare
robshakir
reviewed
Jul 31, 2024
feature/gribi/otg_tests/gribigo_compliance_test/gribigo_compliance_test.go
Outdated
Show resolved
Hide resolved
feature/gribi/otg_tests/gribigo_compliance_test/gribigo_compliance_test.go
Outdated
Show resolved
Hide resolved
feature/gribi/otg_tests/gribigo_compliance_test/gribigo_compliance_test.go
Show resolved
Hide resolved
feature/gribi/otg_tests/gribigo_compliance_test/gribigo_compliance_test.go
Outdated
Show resolved
Hide resolved
feature/gribi/otg_tests/gribigo_compliance_test/gribigo_compliance_test.go
Show resolved
Hide resolved
feature/gribi/otg_tests/gribigo_compliance_test/gribigo_compliance_test.go
Show resolved
Hide resolved
feature/gribi/otg_tests/gribigo_compliance_test/gribigo_compliance_test.go
Show resolved
Hide resolved
11f61ca
to
638525d
Compare
robshakir
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one correction.
feature/gribi/otg_tests/gribigo_compliance_test/gribigo_compliance_test.go
Show resolved
Hide resolved
frasieroh
pushed a commit
to aristanetworks/openconfig-featureprofiles
that referenced
this pull request
Aug 5, 2024
ampattan
pushed a commit
to nokia/featureprofiles
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding below test under gribi_compliance_test.go which is not covered here..
Add IPEntry which references to NH which has down port
Reference for another PULL created for compliance.go Library is
openconfig/gribigo#239