Skip to content

Commit

Permalink
RT-1.28: Invert the verification for removal testcase (#3694)
Browse files Browse the repository at this point in the history
The testcase was waiting for the prefix to exist, but
checking for it to NOT exist. It would fail when the
prefix hasn't been removed by the time Await() function
gets called. The fix is to invert the check and wait for
the prefix removal.
  • Loading branch information
yini101 authored Jan 27, 2025
1 parent 79aa0be commit bc286d0
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -486,8 +486,8 @@ func verifyNonMatchingCommunityTelemetry(t *testing.T, dut *ondatra.DUTDevice, a
}

_, ok := gnmi.WatchAll(t, ate.OTG(), gnmi.OTG().IsisRouter("devIsis").LinkStateDatabase().LspsAny().Tlvs().ExtendedIpv4Reachability().Prefix(advertisedIPv4.address).State(), 30*time.Second, func(v *ygnmi.Value[*otgtelemetry.IsisRouter_LinkStateDatabase_Lsps_Tlvs_ExtendedIpv4Reachability_Prefix]) bool {
prefix, present := v.Val()
return present && prefix.GetPrefix() == advertisedIPv4.address
_, present := v.Val()
return !present
}).Await(t)
if ok {
t.Errorf("Prefix found, not want: %s", advertisedIPv4.address)
Expand Down Expand Up @@ -699,8 +699,8 @@ func verifyNonMatchingCommunityTelemetryV6(t *testing.T, dut *ondatra.DUTDevice,
}

_, ok := gnmi.WatchAll(t, ate.OTG(), gnmi.OTG().IsisRouter("devIsis").LinkStateDatabase().LspsAny().Tlvs().Ipv6Reachability().Prefix(advertisedIPv6.address).State(), 60*time.Second, func(v *ygnmi.Value[*otgtelemetry.IsisRouter_LinkStateDatabase_Lsps_Tlvs_Ipv6Reachability_Prefix]) bool {
prefix, present := v.Val()
return present && prefix.GetPrefix() == advertisedIPv6.address
_, present := v.Val()
return !present
}).Await(t)
if ok {
t.Errorf("Prefix found, not want: %s", advertisedIPv6.address)
Expand Down

0 comments on commit bc286d0

Please sign in to comment.