Add File module #15
Merged
Add File module #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
njordr
commented
Oct 10, 2024
njordr
commented
- Add File API in StartedTestStep
njordr
force-pushed
the
fea/file_object
branch
from
3ff4193 to
8a7540e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files |
mimir-d
requested changes
Oct 10, 2024
Signed-off-by: mimir-d <[email protected]>
Signed-off-by: mimir-d <[email protected]>
Signed-off-by: mimir-d <[email protected]>
mimir-d
force-pushed
the
fea/file_object
branch
from
733056f to
3632d11
Compare
mimir-d
approved these changes
Oct 10, 2024
| is_snapshot, | ||
| ..Default::default() | ||
| uri, | ||
| is_snapshot: false, |
There was a problem hiding this comment.
what happened with the ..Default::default()? did i remove it in the branch fix?
There was a problem hiding this comment.
Nope, the problem is Uri that doesn't have a default
src/output/file.rs
Outdated
| /// | ||
| /// let uri = Uri::parse("file:///tmp/foo").unwrap(); | ||
| /// let file = File::builder("name", uri) | ||
| /// .is_snapshot(true) | ||
| /// .description("description") | ||
| /// .content_type("text/plain") | ||
| /// .content_type(Mime::from_str("text/plain").unwrap()) |
There was a problem hiding this comment.
https://docs.rs/mime/latest/mime/constant.TEXT_PLAIN.html
the point was to not have arbitrary strings
There was a problem hiding this comment.
need to fix this before merge
Signed-off-by: Giovanni Colapinto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.