[DASH] Update dash flow and dash tunnel #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jimmyzhai
commented
Oct 24, 2024
jimmyzhai
commented
- Update SAI of dash flow to align with its p4 table in dash-pipeline
- Update SAI of dash tunnel to align with its p4 table in dash-pipeline
Signed-off-by: Junhua Zhai <[email protected]>
kcudnik
reviewed
Oct 24, 2024
experimental/saitypesextensions.h
Outdated
Comment on lines
192
to
212
| SAI_DASH_FLOW_ACTION_NONE = 0, | ||
|
|
||
| SAI_DASH_FLOW_ACTION_ENCAP_U0 = 1, | ||
|
|
||
| SAI_DASH_FLOW_ACTION_ENCAP_U1 = 2, | ||
|
|
||
| SAI_DASH_FLOW_ACTION_SET_SMAC = 4, | ||
|
|
||
| SAI_DASH_FLOW_ACTION_SET_DMAC = 8, | ||
|
|
||
| SAI_DASH_FLOW_ACTION_SNAT = 16, | ||
|
|
||
| SAI_DASH_FLOW_ACTION_DNAT = 32, | ||
|
|
||
| SAI_DASH_FLOW_ACTION_NAT46 = 64, | ||
|
|
||
| SAI_DASH_FLOW_ACTION_NAT64 = 128, | ||
|
|
||
| SAI_DASH_FLOW_ACTION_SNAT_PORT = 256, | ||
|
|
||
| SAI_DASH_FLOW_ACTION_DNAT_PORT = 512, |
There was a problem hiding this comment.
mayeb use arrows << like other to easy spot which bit is turned on?
kcudnik
reviewed
Oct 24, 2024
Comment on lines
+40
to
+41
| #include <saiexperimentaldashtunnel.h> | ||
| #include <saiexperimentaldashha.h> |
There was a problem hiding this comment.
Why not? Here the list has included saiexperimentaldashappliance.h, saiexperimentaldashflow.h, saiexperimentaldashmeter.h, saiexperimentaldashvip.h, etc. The list is automatically updated while make sai-headers in DASH to have header files of all dash objects.
There was a problem hiding this comment.
since no item is used from included files, so including them is redundant
zhixiongniu
approved these changes
Oct 25, 2024
Signed-off-by: Junhua Zhai <[email protected]>
kcudnik
approved these changes
Oct 25, 2024
erohsik
pushed a commit
to erohsik/SAI
that referenced
this pull request
Nov 7, 2024
Update SAI of dash flow to align with its p4 table in dash-pipeline Update SAI of dash tunnel to align with its p4 table in dash-pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.