Add MAC remote loopback to the port loopback enums. #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Beresford <[email protected]>
kcudnik
approved these changes
Dec 7, 2023
|
Thanks for the (quick) review this morning. @rlhui if there are no concerns, can this be merged? |
|
@rlhui do we need to get any other LGTMs on this? |
|
Will try to merge this week
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: mikeberesford ***@***.***>
Sent: Wednesday, December 13, 2023 1:31:37 PM
To: opencomputeproject/SAI ***@***.***>
Cc: Rita Hui ***@***.***>; Mention ***@***.***>
Subject: Re: [opencomputeproject/SAI] Add MAC remote loopback to the port loopback enums. (PR #1934)
@rlhui<https://github.com/rlhui> do we need to get any other LGTMs on this?
—
Reply to this email directly, view it on GitHub<#1934 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALT3ETUTJQ4Z5MSLBVYJWOLYJINDTAVCNFSM6AAAAABAKDITCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJUG4ZTCMJQGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@JaiOCP would you please review? |
|
@mikeberesford Can you clarify more in comments. In these loopback modes traffic will traverse over the cable and will loopbacked at the remote end by either PHY or MAC, correct? |
JaiOCP
approved these changes
Dec 21, 2023
saiarcot895
added a commit
to saiarcot895/sonic-sairedis
that referenced
this pull request
Jan 26, 2024
The primary purpose of this is to bring in support for compiling on Debian Bookworm. This brings in the following changes: * Update the Doxyfile for doxygen in Debian Bookworm (opencomputeproject/SAI#1946) * Enable sai_uint16_t in ProcessStructValueType Struct Member (opencomputeproject/SAI#1949) * [meta] Add support for port stat extensions (opencomputeproject/SAI#1947) * [meta] Add custom range start end values check (opencomputeproject/SAI#1945) * Cable diagnostics attribute added (opencomputeproject/SAI#1894) * Add attributes to disable L3 rewrites (opencomputeproject/SAI#1924) * Add MAC remote loopback to the port loopback enums. (opencomputeproject/SAI#1934) * [TAM] Granular counter subscription (opencomputeproject/SAI#1670) Signed-off-by: Saikrishna Arcot <[email protected]>
JaiOCP
pushed a commit
to JaiOCP/SAI
that referenced
this pull request
Mar 7, 2024
…ct#1934) Signed-off-by: Mike Beresford <[email protected]> Add a MAC remote loopback type to sai_port_loopback_mode_t. This is the MAC-layer equivalent of SAI_PORT_LOOPBACK_MODE_PHY_REMOTE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a MAC remote loopback type to sai_port_loopback_mode_t. This is the MAC-layer equivalent of SAI_PORT_LOOPBACK_MODE_PHY_REMOTE.