Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] Update message for struct size check #1929

Merged
merged 1 commit into from
Nov 25, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion meta/saisanitycheck.c
Original file line number Diff line number Diff line change
Expand Up @@ -5594,7 +5594,10 @@ void check_struct_and_union_size()
* community, to allow binary compatibility break. When this happens, a
* specific comment should be added here why that struct change happened.
*
* TODO: We need to figure out to do this automatically.
* This is already done automatically using size.sh and size.pl, but this
* only works when git repository is present, since check is getting that
* data from previous commit. We still need to preserve some of those check
* her.
*/

/* unions */
Expand Down