Issue/2

[alirashidAR]

Pull Request #2

Description

Created functionality to pull data from the pv-live library in the fetch_pvlive_data.py file.

Fixes

Summary of Changes

• Implemented methods to interact with the pv-live library.
• Added test cases in tests/data/test_pvlive_data.py to verify the functionality.

How Has This Been Tested?

The following tests were implemented and verified using pytest:

1. Test for get_latest_data: Ensures the method fetches the latest data with the correct parameters.
2. Test for get_data_between: Validates the method fetches data for a specified time range.
3. Test for get_data_at_time: Checks the method fetches data for a specific timestamp.

• Yes

Checklist:

• My code follows OCF's coding style guidelines
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have checked my code and corrected any misspellings

[jcamier]

@alirashidAR this is great. Thanks for doing this. I recommend we change the print statements to logging.

import logging
logger = logging.getLogger(__name__)
...
logger.error(e) instead of print statements (f"Error: {e}") etc.
or 
logger.exception("Problem getting data...) the traceback is already included in this case

[alirashidAR]

Sure , I'll make the changes. Thank you !

[alirashidAR]

@jcamier I've made the necessary changes , please take a look.

[jcamier]

@alirashidAR Looks good to me.
@peterdudfield do you approve to merge?

[peterdudfield]

Next step @alirashidAR is to run this code, and collect the data from this? Would you be up for this?

[peterdudfield]

sorry i missed this, but entity_type should be "gsp"

[alirashidAR]

Sorry about that, I'll create a pull request to change the default entity type to gsp