Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add windnet model #155

Merged
merged 12 commits into from
Dec 17, 2024
Merged

add windnet model #155

merged 12 commits into from
Dec 17, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Dec 16, 2024

Pull Request

Description

Deploy wind net for ad sites

#156

How Has This Been Tested?

CI tests + ran locally

Screenshot 2024-12-16 at 18 14 29

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review December 16, 2024 18:25
@@ -77,7 +77,7 @@ def get_generation_data(
if client == "ruvnl":
start = timestamp - dt.timedelta(hours=1)
elif client == "ad":
start = timestamp - dt.timedelta(hours=3)
start = timestamp - dt.timedelta(hours=25)
Copy link
Member

@Sukh-P Sukh-P Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change because of data quality issues or we are using a lot more wind history?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look at https://huggingface.co/openclimatefix/windnet_ad_sites/blob/main/data_config.yaml and have answered my own question, makes sense since we have a day of wind history

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using a bunch f wind history yeah, over a day

@peterdudfield peterdudfield merged commit f294da0 into main Dec 17, 2024
3 checks passed
@peterdudfield peterdudfield deleted the issue/ad-wind branch December 17, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants