TASK-6754 - Create cohort with more than 1000 samples lead to MongoDB restarts #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-coll
reviewed
Oct 15, 2024
| updateFamilyReferenceInIndividuals(clientSession, family, missingIndividualIds, oldIndividualIds); | ||
| updateRoles = true; | ||
| familyMemberIds = new ArrayList<>(newIndividualIds); | ||
| SnapshotVersionedMongoDBAdaptor.FunctionWithException<Family> updateFamilyReferences = (familyList) -> { |
There was a problem hiding this comment.
This extra large lambda could have been moved to a private function, with something in the name that hints you that the function must be called from some special environment, or as a callback:
private updatefamilyReferencesCallback(List<Document> familyList, ... )Or even have an internal private static class to make it even clearer. This might be usefull if you wanted to add extra functionality
j-coll
approved these changes
Oct 15, 2024
j-coll
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.