Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK-5245 - Regular users (no admin users) with write clinical analysis permission cannot save variants in the sample variant browser #899

Merged
merged 16 commits into from
Oct 1, 2024
Merged

TASK-5245 - Regular users (no admin users) with write clinical analysis permission cannot save variants in the sample variant browser #899

merged 16 commits into from
Oct 1, 2024

Conversation

imedina
Copy link
Member

@imedina imedina commented Apr 1, 2024

No description provided.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gpveronica gpveronica marked this pull request as draft September 3, 2024 10:44
@gpveronica gpveronica changed the base branch from release-2.12.x to release-3.2.x September 5, 2024 10:56
@gpveronica
core: WIP Re-implement permissions implementation, #TASK-5245
be5cd86 
Signed-off-by: gpveronica <[email protected]>
@gpveronica
wc: WIP Add simplifyPermissions, #TASK-5245
443cdbf 
Signed-off-by: gpveronica <[email protected]>
@gpveronica
wc: Add simplifyPermissions, #TASK-5245
0e872d6 
Signed-off-by: gpveronica <[email protected]>
@gpveronica
wc: Add simplifyPermissions and fix algorithm, #TASK-5245
9565638 
Signed-off-by: gpveronica <[email protected]>
@gpveronica
wc: WiP Fix NONE case, #TASK-5245
07f2124 
Signed-off-by: gpveronica <[email protected]>
@gpveronica
wc: Consider EXECUTE_JOBS and minor changes requested, #TASK-5245
efa9d54 
Signed-off-by: gpveronica <[email protected]>
@gpveronica
wc: Minor clean, #TASK-5245
dfe7db8 
Signed-off-by: gpveronica <[email protected]>
@gpveronica
wc: Refactor permissions method name and add simplifyPermission param…
d64cf30 
…eter, #TASK-5245

Signed-off-by: gpveronica <[email protected]>
@gpveronica gpveronica marked this pull request as ready for review September 18, 2024 15:22
@gpveronica gpveronica requested a review from jmjuanes September 18, 2024 15:22
jmjuanes
jmjuanes previously approved these changes Sep 20, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
20.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@gpveronica gpveronica requested a review from jmjuanes October 1, 2024 11:27
@gpveronica gpveronica merged commit 9030183 into release-3.x.x Oct 1, 2024
3 of 4 checks passed
@gpveronica gpveronica deleted the TASK-5245 branch October 1, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmjuanes jmjuanes jmjuanes approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imedina @jmjuanes @gpveronica