cicd: final fix maven secrets properties

opencb · Feb 16, 2023 · 1bfb928 · 1bfb928
1 parent fe0a8f1
commit 1bfb928
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/.github/workflows/build-java-app-workflow.yml b/.github/workflows/build-java-app-workflow.yml
@@ -32,7 +32,7 @@ jobs:
       - uses: actions/upload-artifact@v3
         with:
           name: build-folder
-          path: build/
+          path: build
       - id: get_project_version
         uses: avides/[email protected]
         with:

diff --git a/.github/workflows/deploy-maven-repository-workflow.yml b/.github/workflows/deploy-maven-repository-workflow.yml
@@ -26,14 +26,11 @@ jobs:
           fetch-depth: '10'
       - name: Set up JDK 8
         uses: actions/setup-java@v3
-        #        env:
-        #          MAVEN_USERNAME: ${{ secrets.MAVEN_NEXUS_USER }}
-        #          MAVEN_CENTRAL_TOKEN: ${{ secrets.MAVEN_NEXUS_PASSWORD }}
-        #          MAVEN_GPG_PASSPHRASE: ${{ secrets.MAVEN_GPG_PASSPHRASE }}
         with:
           distribution: 'temurin'
           java-version: '8'
           cache: 'maven'
+          ## Future Nacho and Juanfe, please read this very carefully: DO NOT TOUCH!!!
           server-id: ossrh                                        # Value of the distributionManagement/repository/id field of the pom.xml
           server-username: MAVEN_NEXUS_USER                       # env variable for username in deploy
           server-password: MAVEN_NEXUS_PASSWORD                   # env variable for token in deploy

diff --git a/.github/workflows/task.yml b/.github/workflows/task.yml
@@ -22,7 +22,7 @@ jobs:
   deploy-maven:
     name: Deploy in maven only for renamed versions
     uses: opencb/java-common-libs/.github/workflows/deploy-maven-repository-workflow.yml@TASK-2270
-    needs: [ build, test ]
+    needs: [ build ]
     if: contains( needs.build.outputs.version, 'SNAPSHOT')
     secrets:
       MAVEN_NEXUS_USER: ${{ secrets.MAVEN_NEXUS_USER }}