Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session host bypass fix #784

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

at88mph
Copy link
Member

@at88mph at88mph commented Jan 22, 2025

This PR addresses a diagnosis need to set a separate hostname to bypass some proxies, or potentially host user sessions (workload) on a different cluster or host.

Key Changes:

  1. Hostname configuration from the SKAHA_SESSIONS_HOSTNAME environment variable.
  2. Cleanup for static utility methods
  3. Added unit tests

@at88mph at88mph requested a review from shinybrar January 22, 2025 22:16
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.00%. Comparing base (25ddfed) to head (f622097).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #784      +/-   ##
============================================
+ Coverage     20.60%   21.00%   +0.40%     
- Complexity      118      122       +4     
============================================
  Files            23       23              
  Lines          1980     1985       +5     
  Branches        270      268       -2     
============================================
+ Hits            408      417       +9     
+ Misses         1521     1519       -2     
+ Partials         51       49       -2     
Flag Coverage Δ
skaha-unittests-coverage 21.00% <ø> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant