Kueue preparation

[at88mph]

Description

This pull request ports the refactored Java from PR #719.

Changes Included

• Introduce KubectlCommandBuilder class.
• Modified core components to use KubectlCommandBuilder.
• Ensured backward compatibility.

Purpose

This refactoring includes helpful changes to isolate the kubectl commands.

Testing

• Unit tests ran
• Ran integration tests to confirm no regressions.
• Performed end-to-end testing.

Related Issues/PRs

• SP-4263 Implement compute quotas #719

Checklist

• Tests added or updated to cover new functionality.
• Code reviewed for adherence to best practices and coding standards.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.60%. Comparing base (f5dd456) to head (15056a8).
Report is 16 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #768      +/-   ##
============================================
+ Coverage     18.61%   20.60%   +1.99%     
- Complexity      102      118      +16     
============================================
  Files            22       23       +1     
  Lines          1961     1980      +19     
  Branches        270      270              
============================================
+ Hits            365      408      +43     
+ Misses         1544     1521      -23     
+ Partials         52       51       -1     

Flag	Coverage Δ
skaha-unittests-coverage	20.60% <ø> (+1.99%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shinybrar]

Most of these changes look good, except we need significant documentation, since we are touching so many files.

To enable docstrings checks, following edits are needed

// build.gradle
spotless {
  java {
    // Interpret all files as utf-8
    encoding 'UTF-8'
    // Only require formatting of files that diff from main
    ratchetFrom 'origin/main'
    // Use the default importOrder configuration
    importOrder()
    // Remove unused imports
    removeUnusedImports()
    // Google Java Format, Android Open Source Project style which uses 4 spaces for indentation
    palantirJavaFormat('2.50.0').formatJavadoc(true)
    // Format annotations on a single line
    formatAnnotations()
    // Checks for javadoc formatting
    checkstyle {
      // Point to the same checkstyle.xml file as the checkstyle task
      configFile file("$rootDir/checkstyle.xml")
    }
  }
}

# checkstyle.xml
<!DOCTYPE module PUBLIC
          "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
          "https://checkstyle.org/dtds/configuration_1_3.dtd">
<module name="Checker">
  <module name="TreeWalker">
    <module name="InvalidJavadocPosition"/>
    <module name="JavadocBlockTagLocation"/>
    <module name="JavadocContentLocation"/>
    <module name="JavadocMethod"/>
    <module name="JavadocVariable"/>
    <module name="JavadocStyle"/>
    <module name="JavadocTagContinuationIndentation"/>
    <module name="MissingJavadocType"/>
    </module>
</module>

Javadoc formatting options are available here: https://checkstyle.sourceforge.io/checks/javadoc/index.html

[at88mph]

Most of these changes look good, except we need significant documentation, since we are touching so many files.

To enable docstrings checks, following edits are needed

// build.gradle
spotless {
  java {
    // Interpret all files as utf-8
    encoding 'UTF-8'
    // Only require formatting of files that diff from main
    ratchetFrom 'origin/main'
    // Use the default importOrder configuration
    importOrder()
    // Remove unused imports
    removeUnusedImports()
    // Google Java Format, Android Open Source Project style which uses 4 spaces for indentation
    palantirJavaFormat('2.50.0').formatJavadoc(true)
    // Format annotations on a single line
    formatAnnotations()
    // Checks for javadoc formatting
    checkstyle {
      // Point to the same checkstyle.xml file as the checkstyle task
      configFile file("$rootDir/checkstyle.xml")
    }
  }
}

# checkstyle.xml
<!DOCTYPE module PUBLIC
          "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
          "https://checkstyle.org/dtds/configuration_1_3.dtd">
<module name="Checker">
  <module name="TreeWalker">
    <module name="InvalidJavadocPosition"/>
    <module name="JavadocBlockTagLocation"/>
    <module name="JavadocContentLocation"/>
    <module name="JavadocMethod"/>
    <module name="JavadocVariable"/>
    <module name="JavadocStyle"/>
    <module name="JavadocTagContinuationIndentation"/>
    <module name="MissingJavadocType"/>
    </module>
</module>

Javadoc formatting options are available here: https://checkstyle.sourceforge.io/checks/javadoc/index.html

That's done, thanks.