Skip to content
This repository has been archived by the owner on Mar 10, 2024. It is now read-only.

OpenCAD 1.0.0 Extravaganza #376

Merged

Conversation

ItsAGeekThing
Copy link
Member

@ItsAGeekThing ItsAGeekThing commented Mar 29, 2021

PR is a Work In Progress
Testing and documentation of bugs is both encouraged and appreciated.

This pull request implements the following changes:

  • Removes commented out code.
    • Commented out code adds bloat and serves no use.
      If it is needed in the future for whatever reason, it can be retrieved from Git history.
  • Remove configuring loggers outside of Debug Mode.
    • There were a couple functions where it was possible for OpenCAD to configure loggers outside of Debug Mode.
  • Resolve unsafe cross-origin.
    • Added rel="noopener" to the Stopwatch to prevents the external resource from abusing (not that they would) window.opener, potentially avoiding a redirect to a malicious URL if using a browser before Chrome 88, Firefox 79, or Safari 12.1.
  • Implement SRI and remove legacy vendor example folders.
    Subresource Integrity allows the browser to verify that resources hosted on an external server were not tampered with.
  • Utilize HTTPS instead of HTTP in included libraries.
  • Starting to bring forward the theming the localization features that we already implemented.
    • Detaches theming from the core code.
    • Eliminates EOL vendor libraries.
  • [Table Columns on Civlian Dashboard #366] Combined dl_type and dl_status in to one column to equalize table content with header(s).
  • Removed SQL directory to reduce the number of places SQL templates need to be updated.
    • Updated oc-install to reference NEW location of sql scripts.
  • [Driver License assign when Identity creation #367] Fixed trimming issue for dl_status selection.
    • Saving/Editing will be addressed in a future PR.
    • Also reported by @AniTexs.
  • Remove superfluous vendors folder. The libraries contaioned with in aren't use in core code but used in themes.
  • Remove cad.php and civilian.php. …
  • Database rewrite. Enough said.
  • Introduce changes to oc-install.sql to be compliant with re-write.
  • Add LIVE_MAP option to oc-config.sample.php.
  • Update database schema.
    • Required chamges for oc-update.sql forthcoming.
  • Move functions in to oc-includes.
    • Remove depecated actions folder.
  • Update installer to support LIVEMAP_URL.
    • Update installer to support WEBHOOK_URL
  • Remove superfluous $testing variable.
    • The subject of settings/defaults for testing needs to revisited.
  • Add reference to oc_config in oc-functions to access CONSTANTS.
  • Update internal libraries to use standard sql table naming conventions.
  • Move debug info to a modal which is only accessible to admins.
    • This ensure debug info doesn't dsitrub EUs.
  • Fix paths in mdt.php for NCIC tools. Strip "/js/" from path.
  • Remove deprecated JIRA widget from ncicAdmin.php.
  • Remove deprecated JIRA widget from error pages plugin.
    • This code should be intefrated directly with the core codebase.
  • Add dashboard.modal.inc.php for oc-start.php.
    • Contaions modal for debug output.
  • Update .gitignore.
  • [Entropy function rewrite #379] Centralize and improve entropy implementation.
  • [White container showing on oc-start when LIVEMAP_URL isn't defined #380] Tweak code to only show content section when LIVEMAP_URL is defined in oc-config."
  • [Proposal to drop support for old versions of PHP. #374/Proposal to drop support for old versions of SQL. #384] Drop support for end-of-life PHP and MySQL/MariaDB versions.
  • [NCIC Editor #389] Renamed weaponPermit to weaponPermitStatus
  • Further modularize theming. Default now uses the "building blocks" in it's includes folder.
    • Themeing no longer relies on oc-includes.
  • Add COMMUNITY_HOMEPAGE constant to oc-config.sample.php.

This PR requires testing. This can be done while in draft state.

Phill J. Fernandes added 30 commits August 15, 2019 12:24
…ANDES/opencad-app:working to release/canary

* commit '2c9d7c2c04cbddf0a840dfd97341f3d7ba23f934':
  * More QOL improvements. * OCPHP-199 Started stringification of various pages.
…ly reflect it's purpose.

* Refactoring of civActions.php
* Refactoring of dispatchActions.php. More will be coming.
* OCPHP-642 Base structure of data management pages is complete. Modals and navigability will come in a later commit.
…ANDES/opencad-app:working to release/canary

* commit 'e4ed2592762c844312b6f86ef62045f2a64e0b63':
  OCPHP-642 * OCPHP-642 Base structure of data management pages is complete. Modals and navigability will come in a later commit.
  * OCPHP-642 Renaming sidebarNav.php to topbarNav.php to more accurately reflect it's purpose. * Refactoring of civActions.php * Refactoring of dispatchActions.php. More will be coming.
* OCPBP-643 topNav.php allows navigation between pages. Will add logic for hiding/showing functions in later commit.
* Added MODERATOR_USER_MANAGER to oc-config.sample.php.
* OCPHP-642 Fixed editCitationType(); to allow numbers to be accepted as input.
…ANDES/opencad-app:working to release/canary

* commit '8c5db55b01dcf7cff60ce1aeb22fd1c8f4c3bb03':
  * OCPHP-648 Finished Phase 1 of Citation Type Manager. (OCPHP-642)
  * OCPHP-642 Fixed reference to radioCodeManager.php * OCPHP-642 Fixed editCitationType(); to allow numbers to be accepted as input.
  * OCPHP-642 Cleaned up data IMP/EXP/RES modal.
  * OCPHP-650 Finished Phase 1 of Incident Type Manager. (OCPHP-642)
  * OCPHP-651 Finished Phase 1 of Radio Codes Manager (OCPHP-642)
  * OCPHP-649 Finished Phase 1 of Departments Manager (OCPHP-642)
  * OCPHP-645 Changed User Management page to use topbarNav.inc.php and topProfile.inc.php (OCPHP-642)
  * OCPHP-642 Added baseline topNav for oc-admin. No logic exists, this will come in a later commit.
  * Fixing includes.
  * OCPHP-642 Enabled Data Import/Export/Reset modal.
  * OCPHP-643 Shuffling around includes and scripts. (OCPHP-642)
  * OCPHP-645 Implemented all User Management functions. (OCPHP-642)
  * Some general refactoring.
  * OCPHP-642 Began work on modal dialogs.
  * More session logic.
  * Adding more session checking logic.
  * Adding logic in various spots to check for active session. * OCPBP-643 topNav.php allows navigation between pages. Will add logic for hiding/showing functions in later commit. * Added MODERATOR_USER_MANAGER to oc-config.sample.php.
…ANDES/opencad-app:working to release/canary

* commit '4bd5f0d5532f1dbdbdb294e0c1b66d7b2a34f764':
  * Restoring missing installer components.
… implementation will come in later commits.
…ANDES/opencad-app:working to release/canary

* commit '945e21025ffa145014be956c3cb2d0a52c2b3ce3':
  * OCPHP-642 Final bit of implementation for Phase 1. 100% lang_key(); implementation will come in later commits.
@phillf phillf requested review from devotedsouls and sudenoh April 18, 2021 12:20
@sudenoh
Copy link
Collaborator

sudenoh commented Apr 18, 2021

Hoping to see this come out without many issues.

@phillf
Copy link
Contributor

phillf commented Apr 18, 2021

@sudenoh Not quite there yet but testing and documenting of bugs would be greatly appreciated.

phillf and others added 4 commits April 18, 2021 20:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phillf phillf marked this pull request as ready for review August 9, 2021 22:50
@phillf
Copy link
Contributor

phillf commented Aug 9, 2021

Per conversation with @ItsAGeekThing:

  • Draft status removed.
  • Review for canary should occur to simplify workflow and allow progress to take place in root repository.

INSTABILITY EXPECTED

@phillf phillf requested review from phillf and removed request for phillf August 9, 2021 22:52
@ItsAGeekThing ItsAGeekThing merged commit 543471a into opencad-community:release/canary Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.