Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(swr-openapi): add custom error types to query builder #2147

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SSlime-s
Copy link

@SSlime-s SSlime-s commented Feb 9, 2025

Changes

close #2136

Added a new Type Parameter, FetcherError, to createQueryHook, createImmutableHook, and createInfiniteHook.

It allows you to include FetcherError to the type of the error in the return value of useQuery.

By default, it is set to never to maintain backward compatibility.

Why this is needed is detailed in issue #2136 .

How to Review

To avoid breaking VSCode syntax highlighting, "<unique-key>" is assigned to a variable before being used in the type argument.

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@SSlime-s SSlime-s requested a review from a team as a code owner February 9, 2025 10:56
Copy link

netlify bot commented Feb 9, 2025

👷 Deploy request for openapi-ts pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9862782

Copy link

changeset-bot bot commented Feb 9, 2025

⚠️ No Changeset found

Latest commit: 9862782

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Custom Error Types in createQueryHook for Enhanced Error Handling
1 participant