Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't remove null type if a default is present. #2145

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Don't remove null type if a default is present. #2145

wants to merge 3 commits into from

Conversation

luhn
Copy link

@luhn luhn commented Feb 7, 2025 •
edited
Loading

Changes

Fixes #2144

Fixes #2055

How to Review

Pretty straightforward PR

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@luhn luhn requested a review from a team as a code owner February 7, 2025 06:31
@luhn luhn requested a review from htunnicliff February 7, 2025 06:31
@netlify Netlify
Copy link

netlify bot commented Feb 7, 2025 •
edited
Loading

👷 Deploy request for openapi-ts pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 705f3e4

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 705f3e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@luhn luhn force-pushed the nullable-default branch from 7c7ea13 to 1e6f967 Compare February 7, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htunnicliff htunnicliff Awaiting requested review from htunnicliff htunnicliff is a code owner automatically assigned from openapi-ts/maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nullable ignored if non-null default is present nullable property is not nullable in generated code
1 participant
@luhn