-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(metadata): migrate to unbuild #2115
Conversation
🦋 Changeset detectedLatest commit: 6126497 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for openapi-ts canceled.
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but should we do this across the board for all packages? (or am I missing something in how metadata is different / special here?)
Currently we have a mix of It could be interesting to unify the build system we use across the monorepo but as packages are fairly small we might not get much benefits other than unifying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unbuild is great! I wouldn’t mind other packages building with this as well.
Changes
This pull request closes #2097 by migrating to unbuild with CommonJS support. It also does a cleanup of unused dependencies in the package.
How to Review
This library should still work as before with ESM and CJS support.