Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(metadata): migrate to unbuild #2115

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

kerwanp
Copy link
Contributor

@kerwanp kerwanp commented Jan 23, 2025

Changes

This pull request closes #2097 by migrating to unbuild with CommonJS support. It also does a cleanup of unused dependencies in the package.

How to Review

This library should still work as before with ESM and CJS support.

@kerwanp kerwanp added the openapi-metadata Relevant to openapi-metadata library label Jan 23, 2025
@kerwanp kerwanp requested a review from a team as a code owner January 23, 2025 14:17
@kerwanp kerwanp requested a review from gzm0 January 23, 2025 14:17
@kerwanp kerwanp linked an issue Jan 23, 2025 that may be closed by this pull request
1 task
Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: 6126497

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-metadata Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for openapi-ts canceled.

Name Link
🔨 Latest commit 7acc365
🔍 Latest deploy log https://app.netlify.com/sites/openapi-ts/deploys/679541cf421b710008f699cc

Copy link
Contributor

github-actions bot commented Jan 23, 2025

size-limit report 📦

Path Size
packages/openapi-fetch/dist/index.min.js 6.47 KB (0%)

Copy link
Contributor

@gzm0 gzm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should we do this across the board for all packages? (or am I missing something in how metadata is different / special here?)

@kerwanp
Copy link
Contributor Author

kerwanp commented Jan 24, 2025

Currently we have a mix of tsc and esbuild in packages for ESM and CJS support. And I've implemented unbuild as it is my favorite build system. And I don't have to do much to have multiple entries with cjs, esm and dts.

It could be interesting to unify the build system we use across the monorepo but as packages are fairly small we might not get much benefits other than unifying.

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unbuild is great! I wouldn’t mind other packages building with this as well.

@drwpow drwpow merged commit 0a01774 into main Jan 25, 2025
13 checks passed
@drwpow drwpow deleted the 2097-openapi-metadata-support-for-commonjs branch January 25, 2025 20:02
@openapi-ts-bot openapi-ts-bot mentioned this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openapi-metadata Relevant to openapi-metadata library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[openapi-metadata] Support for CommonJS
3 participants