Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Netlify badge #2065

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Add Netlify badge #2065

merged 3 commits into from
Jan 3, 2025

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Dec 21, 2024

Changes

Adds Netlify Badge because we’re moving hosts for the documentation. And as part of their OSS program they generously donate free hosting in exchange for a badge. Though the docs site has been on Cloudflare until now, Netlify is much friendlier for OSS collaboration and anyone being able to deploy docs previews.

Note: you’ll still see Cloudflare on PRs temporarily, while we give DNS a generous amount of time to switch over. Wouldn’t want to accidentally have the docs site be disabled for some folks during the transition!

CleanShot 2024-12-21 at 15 08 03@2x

How to Review

  • Any feedback on size/placement?

Checklist

N/A

@drwpow drwpow requested a review from a team as a code owner December 21, 2024 22:09
@drwpow drwpow requested a review from kerwanp December 21, 2024 22:09
Copy link

changeset-bot bot commented Dec 21, 2024

⚠️ No Changeset found

Latest commit: 64775e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@drwpow drwpow changed the title Add netlify badge Add Netlify badge Dec 21, 2024
Copy link

netlify bot commented Dec 21, 2024

Deploy Preview for openapi-ts ready!

Name Link
🔨 Latest commit 78e1237
🔍 Latest deploy log https://app.netlify.com/sites/openapi-ts/deploys/67785b8e074ccb00085f631e
😎 Deploy Preview https://deploy-preview-2065--openapi-ts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 21, 2024

size-limit report 📦

Path Size
packages/openapi-fetch/dist/index.min.js 6.47 KB (0%)

@kerwanp
Copy link
Contributor

kerwanp commented Dec 21, 2024

Looks good to me! Is there any other available logo format? I'm really not fan of this box.
And the "Built with" is really confusing

@drwpow
Copy link
Contributor Author

drwpow commented Dec 22, 2024

Looks good to me! Is there any other available logo format? I'm really not fan of this box.

Yeah… they rebranded to a very “tall” logo that doesn’t fit inside a box easily. They have some color options but this is basically the only “badge” version they provide. I kinda agree—maybe I’ll look into another logo that still meets their requirements. They also allow a link without a logo; I can try that as well.

@drwpow drwpow force-pushed the add-netlify-badge branch from 64775e6 to 78e1237 Compare January 3, 2025 21:50
@drwpow
Copy link
Contributor Author

drwpow commented Jan 3, 2025

Simplified it; went with a less-noticeable link that still meets their terms of use requirements

@drwpow drwpow merged commit 411db0b into main Jan 3, 2025
13 checks passed
@drwpow drwpow deleted the add-netlify-badge branch January 3, 2025 21:53
duncanbeevers pushed a commit to duncanbeevers/openapi-typescript that referenced this pull request Jan 3, 2025
* Only check GitHub token for docs build when update needed

* Add Netlify badge

* Use link
drwpow added a commit that referenced this pull request Jan 4, 2025
* Add schema to postTransform options (#2049)

* Add schema to postTransform options

Closes #2013

* fixup! Add schema to postTransform options

Closes #2013

* fixup! Add schema to postTransform options

Closes #2013

* fixup! Add schema to postTransform options

* Add Netlify badge (#2065)

* Only check GitHub token for docs build when update needed

* Add Netlify badge

* Use link

* [ci] release (#2084)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix issue templates (#2088)

* Add feat issues to projects (#2090)

* Use const arrays for OpenAPI enum types

Preserve capitalization of named, exported enum values.
Type exported const values as const, instead of their location within the operations or components schemas.
Derive and export types for enum values from concrete values in const arrays.
Use derived enum value types in operations and components schemas.
Use non-conflicting variable names for composed OpenAPI enums (anyOf: [enum1, enum2])

* Export type-predicates along when enumValues is true

---------

Co-authored-by: Drew Powers <[email protected]>
Co-authored-by: openapi-ts-bot <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants