Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openapi-typescript): build cjs support astToString export #1488

Merged
merged 2 commits into from
Dec 24, 2023

Conversation

liangskyli
Copy link
Contributor

@liangskyli liangskyli commented Dec 15, 2023

Changes

fix: #1482

How to Review

const openapiTS = require('openapi-typescript').default;
const { astToString } = require('openapi-typescript');
// output: [Function: astToString] [AsyncFunction: openapiTS]
console.log('output:',astToString, openapiTS);

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

Copy link

changeset-bot bot commented Dec 15, 2023

⚠️ No Changeset found

Latest commit: 41dd3cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

const openapiTS = require("../dist/index.cjs");

// copy from lib/ts.ts for CJS
function astToString(ast, options) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great proof of that 🙂

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also the original issue was against 7.x beta, so any/all breaking changes are still OK at this point. If you wanted to make any improvements to 6.x you’re also welcome to in a followup PR, although that may be a little stricter on preventing breaking changes.

@drwpow drwpow merged commit 8612b08 into openapi-ts:main Dec 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[email protected] require('openapi-typescript') cannot export the astToString method
2 participants