Allow for more tolerant comment parsing #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-richardson
force-pushed
the
improve_tag_parser_167836
branch
from
bb39826 to
381deac
Compare
okurz
reviewed
Oct 15, 2024
r-richardson
force-pushed
the
improve_tag_parser_167836
branch
from
381deac to
9f829ab
Compare
okurz
approved these changes
Oct 15, 2024
Martchus
reviewed
Oct 15, 2024
yes i'm looking into it though i am a little confused as these pylint errors do not seem to be related to my changes. |
It could just be that a newer pylint version is not happy with some old code. |
Issues arised during work on openSUSE#183
Make comment parser more tolerant by allowing non-printable characters such as e.g. carriage returns, as well as preceding and trailing comment text Related issue: https://progress.opensuse.org/issues/167836
r-richardson
force-pushed
the
improve_tag_parser_167836
branch
from
9f829ab to
e43f39c
Compare
Martchus
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make comment parser more tolerant by allowing non-printable characters such as e.g. carriage returns, as well as preceding and trailing comment text
Related issue: https://progress.opensuse.org/issues/167836