Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date parsing rebased on extracted method - combining #180+#178 #181

Merged

Conversation

okurz
Copy link
Member

@okurz okurz commented May 8, 2024

@okurz okurz changed the title WIP: date parsing rebased on extracted method WIP: date parsing rebased on extracted method - combining #180+#178 May 8, 2024
@okurz okurz force-pushed the feature/date-parsing_rebased_on_extracted_method branch from 65a7da6 to dad25d3 Compare May 8, 2024 14:39
@okurz okurz force-pushed the feature/date-parsing_rebased_on_extracted_method branch from dad25d3 to de293ae Compare May 8, 2024 14:49
@okurz okurz changed the title WIP: date parsing rebased on extracted method - combining #180+#178 date parsing rebased on extracted method - combining #180+#178 May 9, 2024
@okurz okurz marked this pull request as ready for review May 9, 2024 15:51
@okurz
Copy link
Member Author

okurz commented May 9, 2024

@michaelgrifalconi ok like this?

@michaelgrifalconi
Copy link

michaelgrifalconi commented May 10, 2024

I still feel it got more complicated just to please the formatting rules, but looks overall fine.
Nice thing the return None, was not aware of that.
Thank you!

@okurz
Copy link
Member Author

okurz commented May 10, 2024

I still feel it got more complicated just to please the formatting rules, but looks overall fine.

It's important to just agree on styling rules, enforce them with automation and stick to it. If you feel in general a rule should be changed I suggest you propose that in a separate pull request but chances are slim we will agree on diluting the upstream python community rules

@okurz okurz merged commit 463d5de into openSUSE:master May 10, 2024
3 checks passed
@okurz okurz deleted the feature/date-parsing_rebased_on_extracted_method branch May 10, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants