Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add command runner workflow #44

Merged
merged 4 commits into from
Sep 16, 2024
Merged

add command runner workflow #44

merged 4 commits into from
Sep 16, 2024

Conversation

ntduan
Copy link
Collaborator

@ntduan ntduan commented Sep 12, 2024

fix issue #2

@ntduan ntduan requested a review from xlc September 12, 2024 03:57
xlc
xlc requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have most of the JS code in .js file and only load from .js file in yml file? it will be easier to read & test

.github/workflows/command-runner.yml Outdated Show resolved Hide resolved
.github/workflows/command-runner.yml Outdated Show resolved Hide resolved
@ntduan
Copy link
Collaborator Author

ntduan commented Sep 14, 2024

can we have most of the JS code in .js file and only load from .js file in yml file? it will be easier to read & test

fixed

@ntduan ntduan requested a review from xlc September 14, 2024 07:51
@xlc xlc merged commit 397c472 into master Sep 16, 2024
2 checks passed
@xlc xlc deleted the command-runner branch September 16, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntduan @xlc