add bls #29
Merged
add bls #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
reviewed
Jul 2, 2024
Utils/Sources/Utils/BLS.swift
Outdated
| public struct BLS { | ||
| public let secretKey: Data32 | ||
|
|
||
| public var publicKey: Data48 { |
There was a problem hiding this comment.
I think best to make this a let and initialize it at init to avoid the possibility to generate pub key too many times
There was a problem hiding this comment.
GP defines BLS pubkey to be 144 bytes. Maybe it is the compressed G1 element (48 bytes) + compressed G2 element (96 bytes)
|
this is probably fine for now. we need to wait for some related test vectors to confirm the encoding format |
xlc
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3