Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update RPC ChainHandler #268

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

update RPC ChainHandler #268

wants to merge 11 commits into from

Conversation

MacOMNI
Copy link
Contributor

@MacOMNI MacOMNI commented Jan 23, 2025

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.49835% with 50 lines in your changes missing coverage. Please review.

Project coverage is 80.49%. Comparing base (65a0f46) to head (486706a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
Node/Sources/Node/NodeDataSource.swift 0.00% 34 Missing ⚠️
RPC/Tests/RPCTests/ChainHandlesTests.swift 91.66% 7 Missing ⚠️
...rces/Blockchain/Config/ProtocolConfig+Preset.swift 0.00% 3 Missing ⚠️
Node/Sources/Node/NetworkingProtocol/Network.swift 0.00% 3 Missing ⚠️
RPC/Sources/RPC/Handlers/ChainHandlers.swift 90.47% 2 Missing ⚠️
RPC/Sources/RPC/JSONRPC/JSONRPCController.swift 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage   78.70%   80.49%   +1.78%     
==========================================
  Files         299      303       +4     
  Lines       23977    24338     +361     
==========================================
+ Hits        18871    19590     +719     
+ Misses       5106     4748     -358

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MacOMNI MacOMNI marked this pull request as ready for review January 23, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MacOMNI @xlc