feat: update to storybook@6 and more #12
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at update to Storybook@6+ and most things seem copacetic.
There is one case where the build currently converts the following code found in
@storybook/web-components/dist/client/preview/render.js
:to
Which fails in that
lit-html
does't not provide adefault
export.Any thoughts on how to manage that?
When we find the right settings to correct that, I'd love to see this published as a major version bump of Storybook Prebuilt so that users can opt-in to using it. There are some public API changes to
src/core-events.js
where the corresponding exports in Storybook have been removed/changed. Sound good?