Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #58

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix typo #58

wants to merge 2 commits into from

Conversation

peschee
Copy link

@peschee peschee commented Aug 28, 2024

No description provided.

@Westbrook
Copy link

Doesn't look like we've got the changeset bot on this repo, but we'd likely need one to ensure a successful release of this change.

@bennypowers
Copy link
Member

I added the bot here
might help to change the state of the pr

@bennypowers bennypowers marked this pull request as draft August 28, 2024 17:17
@bennypowers bennypowers marked this pull request as ready for review August 28, 2024 17:19
@michaelwarren1106
Copy link
Collaborator

lgtm, though I dont think i have access to publish this...not even sure how publication is done for this repo..its been so long haha

@bennypowers
Copy link
Member

@peschee please manually add a a patch changeset with npx changesets

Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 47cd985

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@open-wc/form-control Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@peschee
Copy link
Author

peschee commented Aug 29, 2024

Done. One thing I noticed: when running npm i locally, the lockfile gets changes:

diff --git a/package-lock.json b/package-lock.json
index f79edcb..bfabf69 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -10558,12 +10558,12 @@
     },
     "packages/form-control": {
       "name": "@open-wc/form-control",
-      "version": "0.7.0",
+      "version": "1.0.0",
       "license": "MIT"
     },
     "packages/form-helpers": {
       "name": "@open-wc/form-helpers",
-      "version": "0.2.3",
+      "version": "1.0.0",
       "license": "MIT"
     }
   }

Probably a separate issue…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants