feat: recognize @customElement and @customelement JSDoc tags for defining an element
#287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for custom-elements-manifest-analyzer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JamesIves
changed the title
@customElement and @customelement tags for defining an element
JamesIves
changed the title
@customElement and @customelement tags for defining an element@customElement and @customelement JSDoc tags for defining an element
|
Thank you sir, will release in a minute |
|
Published in 0.10.4 Are you using custom elements at blizzard? |
|
Yeah - our design system leverages custom elements with Lit 😄 |
|
Cool, is it in production anywhere I can see it in action? |
|
I'll shoot you a DM on the Lit Discord with some links |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related discussion: 43081j/eslint-plugin-wc#142
This pull request includes a small change to the
classJsDocPluginfunction in theclass-jsdoc.jsfile. The change adds support for additional tag names in the JSDoc analysis.packages/analyzer/src/features/analyse-phase/class-jsdoc.js: Added support forcustomElementandcustomelementtags in theclassJsDocPluginfunction.