Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pyqt6 #3

Merged
merged 41 commits into from
Mar 5, 2024
Merged

Test pyqt6 #3

merged 41 commits into from
Mar 5, 2024

Conversation

m-kuhn
Copy link
Contributor

@m-kuhn m-kuhn commented Feb 12, 2024

Fixes #8
Fixes #9

@m-kuhn m-kuhn force-pushed the fix-pyqt6 branch 4 times, most recently from f9707aa to 2a0a482 Compare February 12, 2024 20:42
@Neumann-A
Copy link
Member

image

I think we need to delete something but the questions is what? Is something collecting a huge amount of logs/artifacts?

@Thomas1664
Copy link

Thomas1664 commented Feb 20, 2024

I think we need to delete something but the questions is what? Is something collecting a huge amount of logs/artifacts?

I think the binary cache accumulated many entries from every PR run and source files are big as well.

Why do you only have 0,5 GB? I have 2 GB

@Neumann-A
Copy link
Member

Why do you only have 0,5 GB? I have 2 GB

That seems to be the difference between Free and Pro. My personal account also has 2 GB but the organization has only 0,5 GB updating that costs 4 $ per user per month which is kind of strange unless the GB size also increases with the number of users. I wonder what "user" means here in organization context.

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Feb 22, 2024

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Feb 22, 2024

I enabled "public" packages now in https://github.com/organizations/open-vcpkg/settings/packages

@Neumann-A
Copy link
Member

If the same packages for users apply to orgs the package stuff needs to be moved to somewhere else in the future. (E.g. there can only be one repo with vcpkg packages.) For example I have a private repo called my-vcpkg-packages which just handles the package stuff for all other repos due to that limitation

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Feb 22, 2024

If the same packages for users apply to orgs the package stuff needs to be moved to somewhere else in the future. (E.g. there can only be one repo with vcpkg packages.)

why?

@Neumann-A
Copy link
Member

why?

Strange limitation of github if i remember correctly. You'll get strange errors if another repo tries to push github packages.

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Feb 23, 2024

why?

Strange limitation of github if i remember correctly. You'll get strange errors if another repo tries to push github packages.

It might be related to packages which are linked to a repository?
Reading about this, github suggests linking packages to a repository for ACL reasons. As I think we don't care and want everything public, this should be a non issue. If this is really the reason for the aforementioned limitation.

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Mar 2, 2024

Thanks for the add_dll_directory patch @Neumann-A c38149f

@Neumann-A
Copy link
Member

Thanks for the add_dll_directory patch @Neumann-A c38149f

No problem more or less stolen from conda ;)

But be aware that embedded python needs a slightly better approach: The path const wchar_t python_path[] = L"\\tools\\python3"; can be \\tools\\<anything> in reality. Currently the patch only enables python3 itself to find the dlls. Stuff embedding python3 will still not be able to find the dlls without additional setup.

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Mar 3, 2024

But be aware that embedded python needs a slightly better approach: The path const wchar_t python_path[] = L"\\tools\\python3"; can be \\tools\\<anything> in reality. Currently the patch only enables python3 itself to find the dlls. Stuff embedding python3 will still not be able to find the dlls without additional setup.

Sounds like this should be done when loading the python dll (instead of executable) instead ideally?

Any last comments from your side before merging this?

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Mar 4, 2024

I'll merge later today unless there's an additional comment coming.
I'm quite happy with what's here. Even if it's not perfect yet, it's a good starting point for future improvements.

@m-kuhn m-kuhn merged commit 9e7e663 into main Mar 5, 2024
4 checks passed
@m-kuhn m-kuhn deleted the fix-pyqt6 branch March 5, 2024 06:23
@m-kuhn m-kuhn mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

smoke test add_dll_directory
3 participants