Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python to 3.11.9 #29

Merged
merged 4 commits into from
May 12, 2024
Merged

Bump python to 3.11.9 #29

merged 4 commits into from
May 12, 2024

Conversation

m-kuhn
Copy link
Contributor

@m-kuhn m-kuhn commented May 12, 2024

python 3.11.9 requires openssl 3.3 which requires a baseline update which brings Qt 6.7.0 which requires PyQt 6.7.0 which requires sip, pyqt-builder and sip-pyqt6 updates

Additionally, pyqt-builder artifact filenames are unstable

@m-kuhn m-kuhn mentioned this pull request May 12, 2024
@m-kuhn m-kuhn force-pushed the bump-python-3-11-9 branch from fa2b164 to 2f3e74f Compare May 12, 2024 08:31
@m-kuhn m-kuhn force-pushed the bump-python-3-11-9 branch 3 times, most recently from 4776ff1 to 86778a2 Compare May 12, 2024 09:21
@@ -1,8 +1,9 @@
vcpkg_from_pythonhosted(
OUT_SOURCE_PATH SOURCE_PATH
PACKAGE_NAME PyQt-builder
FILE_NAME pyqt_builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just calculated a filename from package_name ?

Copy link
Contributor Author

@m-kuhn m-kuhn May 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you meant to say "just calculate" without "d".

Compare https://pypi.org/project/PyQt-builder/1.16.2/#files and https://pypi.org/project/PyQt-builder/1.15.4/#files the filenames do not follow a rule. For the standard case following naming conventions FILE_NAME is not required though https://github.com/open-vcpkg/python-registry/pull/29/files#diff-296f6707a6a059f9b1531dcfb0d9038a4d02b772d8e8c4581b5fdf6daf9a44a7R24-R26

@m-kuhn m-kuhn force-pushed the bump-python-3-11-9 branch from 86778a2 to 5a50b44 Compare May 12, 2024 09:53
@m-kuhn m-kuhn merged commit 63c5bfb into main May 12, 2024
4 checks passed
@m-kuhn m-kuhn deleted the bump-python-3-11-9 branch May 12, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants