-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentelemetry-aws: add LambdaResourceDetector
#93
opentelemetry-aws: add LambdaResourceDetector
#93
Conversation
…to detect resource attributes from an AWS Lambda environment. This commits introduces the `LambdaResourceDetector`, that can be used to detect resource attributes from an AWS Lambda environment. A new feature flag has been introduced `aws-lambda` to hide this code when it is not needed. Signed-off-by: thomas.gouveia <[email protected]> Signed-off-by: thomasgouveia <[email protected]>
18a47ab
to
75edc86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. I'd request to make this either a standalone crate in this repo, or part of https://github.com/open-telemetry/opentelemetry-rust-contrib/tree/main/opentelemetry-aws
We want to keep any platform specific (AWS/Azure/GCP etc.) outside of the detectors to better ensure ownership, maintenance in the future.
Hi @cijothomas , no problem, I understand and agree with that vision. What do you think of adding a detector module under |
I am unsure if there is any owner for |
@cijothomas Ok LGTM. I'll do it asap. Thanks! |
Signed-off-by: thomasgouveia <[email protected]>
LambdaResourceDetector
LambdaResourceDetector
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
=======================================
+ Coverage 52.3% 56.4% +4.1%
=======================================
Files 38 39 +1
Lines 4967 5429 +462
=======================================
+ Hits 2598 3064 +466
+ Misses 2369 2365 -4 ☔ View full report in Codecov by Sentry. |
Changes
This PR introduces the
LambdaResourceDetector
, which can detect resource attributes from an AWS Lambda environment. A new feature flag has been introduceddetector-aws-lambda
to hide this code when it is not needed.It is based on the Go implementation.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changesPart of #94