Remove server feature from tonic in opentelemetry-stackdriver #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opentelemetry-stackdriver does not need the server implementation from tonic, which brings in axum etc. This change brings in all features other than that, which are needed for the client implementation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=====================================
Coverage 54.2% 54.2%
=====================================
Files 42 42
Lines 6276 6276
=====================================
Hits 3402 3402
Misses 2874 2874 ☔ View full report in Codecov by Sentry. |
fiadliel
changed the title
lalitb
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147
Changes
opentelemetry-stackdriver does not need the server implementation from tonic, which brings in axum etc. This change brings in all features other than that, which are needed for the client implementation.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes