Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: opentelemetry-stackdriver includes unnecessary axum via tonic #147

Open
fiadliel opened this issue Jan 10, 2025 · 0 comments · May be fixed by #148
Open

[Feature]: opentelemetry-stackdriver includes unnecessary axum via tonic #147

fiadliel opened this issue Jan 10, 2025 · 0 comments · May be fixed by #148
Labels
enhancement New feature or request

Comments

@fiadliel
Copy link
Contributor

fiadliel commented Jan 10, 2025

Related Problems?

opentelemetry-stackdriver includes the server feature, via the transport feature, which is included in default features.
This unnecessary feature brings in a large number of dependencies, including axum.

$ cargo tree -e features -p axum --invert
axum v0.7.9
└── tonic v0.12.3
    ├── tonic feature "channel"

The package should not include this dependency.

What component are you working with?

opentelemetry-stackdriver

Describe the solution you'd like:

tonic should not include the default features. Instead, it should include current features, except for server.

Considered Alternatives

No response

Additional Context

This was previously discussed in hyperium/tonic#1014 in 2022, but wasn't then possible.
It looks feasible since 0.12.0, see hyperium/tonic#1574

@fiadliel fiadliel added the enhancement New feature or request label Jan 10, 2025
@fiadliel fiadliel linked a pull request Jan 10, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant