[service] create service/hostcapabilities package #12375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12375 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 467 467
Lines 25623 25623
=======================================
Hits 23456 23456
Misses 1768 1768
Partials 399 399 ☔ View full report in Codecov by Sentry. |
mx-psi
reviewed
Feb 14, 2025
jackgopack4
force-pushed
the
expose-getmoduleinfos-component-host
branch
from
1a83c3b to
5e6ee04
Compare
jackgopack4
commented
Feb 14, 2025
| "go.opentelemetry.io/collector/service/internal/builders" | ||
| "go.opentelemetry.io/collector/service/internal/moduleinfo" | ||
| "go.opentelemetry.io/collector/service/internal/status" | ||
| "go.opentelemetry.io/collector/service/internal/zpages" | ||
| ) | ||
|
|
||
| // TODO: remove as part of https://github.com/open-telemetry/opentelemetry-collector/issues/7370 for service 1.0 | ||
| type getExporters interface { |
There was a problem hiding this comment.
is removing this interface in favor of HostCapabilities what you intended @mx-psi ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
create
service/hostcapabilitiespackage to exposeGetModuleInfos()from service/host. Also moves getExporters interface forGetExporters()to this package.Link to tracking issue
Addresses planned work from #12296
Testing
none, creates interface for existing function
Documentation
changelog yaml