Use os.type instead of os.family (#161)

The semantic conventions define os.type, but the examples use os.family. Let's follow the convention! See also OpAMP spec: https://github.com/open-telemetry/opamp-spec/blob/main/specification.md#agentdescriptionnon_identifying_attributes
open-telemetry · Mar 20, 2023 · 06011e4 · 06011e4
1 parent 34ba098
commit 06011e4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/examples/agent/agent/agent.go b/internal/examples/agent/agent/agent.go
@@ -150,7 +150,7 @@ func (agent *Agent) createAgentIdentity() {
 		},
 		NonIdentifyingAttributes: []*protobufs.KeyValue{
 			{
-				Key: "os.family",
+				Key: "os.type",
 				Value: &protobufs.AnyValue{
 					Value: &protobufs.AnyValue_StringValue{
 						StringValue: runtime.GOOS,

diff --git a/internal/examples/supervisor/supervisor/supervisor.go b/internal/examples/supervisor/supervisor/supervisor.go
@@ -204,7 +204,7 @@ func (s *Supervisor) createAgentDescription() *protobufs.AgentDescription {
 			keyVal("service.version", s.agentVersion),
 		},
 		NonIdentifyingAttributes: []*protobufs.KeyValue{
-			keyVal("os.family", runtime.GOOS),
+			keyVal("os.type", runtime.GOOS),
 			keyVal("host.name", hostname),
 		},
 	}