Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add recipe for Indian Style pizza #38

Merged
merged 5 commits into from
Oct 16, 2023
Merged

feat: add recipe for Indian Style pizza #38

merged 5 commits into from
Oct 16, 2023

Conversation

kumar007ambi
Copy link
Contributor

@kumar007ambi kumar007ambi commented Oct 13, 2023 •
edited by CBID2
Loading

Description

This PR adds the recipe for Indian-style pizza.

What type of PR is this? (check all applicable)

  • [❌ ] 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

#32

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@kumar007ambi
Copy link
Contributor Author

@CBID2 Please add the hactoberfest tag for valid contribution.

@CBID2 CBID2 changed the title Add Regional pizza style to repo Add Indian pizza style to repo Oct 13, 2023
CBID2
CBID2 suggested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kumar007ambi. This is a great entry but itsuits the recipe.md file more. This repository is about talking the origin of your hometown’s pizza and what’s typically in it. Check out the Japanese style pizza entry for reference.

@kumar007ambi
Copy link
Contributor Author

kumar007ambi commented Oct 13, 2023 •
edited
Loading

Basically, I have to add this recipe to pizza-recipes.md file

@CBID2
Copy link
Contributor

CBID2 commented Oct 13, 2023 •
edited
Loading

Basicaly, I have to add this recipe to recipe.md file

Yes @kumar007ambi. You can still add Indian pizza to this repository, just add information about it like line 46.

kumar007ambi
kumar007ambi commented Oct 13, 2023
View reviewed changes
Copy link
Contributor Author

@kumar007ambi kumar007ambi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CBID2 I have added This recipe to pizza-recipes.md file

CBID2
CBID2 reviewed Oct 13, 2023
View reviewed changes
pizza-recipes.md Outdated Show resolved Hide resolved
CBID2
CBID2 suggested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kumar007ambi. Your entry looks pretty good. I just gave a suggestion on how you can improve it.

@CBID2 CBID2 changed the title Add Indian pizza style to repo feat: add recipe for Indian Style pizza Oct 13, 2023
CBID2
CBID2 suggested changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kumar007ambi! 😃 I gave you more suggestions on how to improve your recipe. Keep it up! 😄

pizza-recipes.md Outdated Show resolved Hide resolved
pizza-recipes.md Outdated Show resolved Hide resolved
pizza-recipes.md Outdated Show resolved Hide resolved
pizza-recipes.md Outdated Show resolved Hide resolved
pizza-recipes.md Outdated Show resolved Hide resolved
pizza-recipes.md Outdated Show resolved Hide resolved
@kumar007ambi
Copy link
Contributor Author

@CBID2 I have a added your suggestions to improve your recipe.Please do not forget to add hactoberfest tag😁.

CBID2
CBID2 suggested changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kumar007ambi. I gave another suggestion.

@CBID2 CBID2 added the hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest label Oct 15, 2023
@kumar007ambi
Copy link
Contributor Author

@CBID2 okay I will add the image for the recipe

@kumar007ambi
Copy link
Contributor Author

@CBID2 Thanks 😁 for the suggestion. I have added image to the recipe.

CBID2
CBID2 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @kumar007ambi

@CBID2 CBID2 merged commit 4bb56e3 into open-sauced:main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBID2 CBID2 CBID2 approved these changes

Assignees

@kumar007ambi kumar007ambi

Labels
💡 feature hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumar007ambi @CBID2