Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add profile kishore rajkumar #189

Merged

Conversation

tech-kishore
Copy link
Contributor

@tech-kishore tech-kishore commented Dec 6, 2023

Description

This PR adds kishore rajkumar as a contributor.

What type of PR is this? (check all applicable)

  • 🤝 Add a contributor
  • 📝 Documentation Update

Contributors checklist (check all applicable)

  • Have you read the Getting Started section thoroughly?

    • ✅ Yes
    • ❌ Not yet
  • How did you add yourself as a contributor?

  • Have you run npm run contributors:generate to generate your profile and the badge on the README?

    • ✅ Yes
    • ❌ No

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

[optional] What GIF best describes this PR or how it makes you feel?

@adiati98
Copy link
Member

adiati98 commented Dec 6, 2023

Hi @tech-kishore ,
Thank you for your PR! 🙌

I see that you made changes in the package-lock.json. We don't want to merge the changes in this file. So, can you fix it to not include them in this PR?
Thank you. 🙂

@tech-kishore
Copy link
Contributor Author

Thanks @adiati98 for the help. Will make the change.

@adiati98 adiati98 enabled auto-merge (squash) December 7, 2023 11:23
auto-merge was automatically disabled December 8, 2023 17:21

Head branch was pushed to by a user without write access

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tech-kishore,
Sorry for not being too clear. What I meant by we don't want to merge the changes in the package-lock.json was for you to revert the changes in this file, and not deleting the file.

I've reverted your changes and this PR is good to go! 🙌

For your future reference, please fill out all the areas in the PR form. I've filled out the PR description for you. :)

If you haven't, you can join our community Discord. 😊
Also, check out our pizza-verse repo if you want to contribute further! 🍕

git merge GIF

@adiati98 adiati98 merged commit 2058282 into open-sauced:main Dec 8, 2023
1 check passed
@tech-kishore
Copy link
Contributor Author

@adiati98 I misunderstood, and I apologize for that mistake on my part!
I appreciate your assistance in finalizing the PR, will consider your advice for future contributions.
Eager to continue learning and making contributions in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants