Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brandon added as a contributor #180

Merged
merged 8 commits into from
Dec 20, 2023
Merged

Brandon added as a contributor #180

merged 8 commits into from
Dec 20, 2023

Conversation

Bradondev
Copy link
Contributor

@Bradondev Bradondev commented Nov 12, 2023 •
edited
Loading

Description

What type of PR is this? (check all applicable)

  • 🤝 Add a contributor

Contributors checklist (check all applicable)

  • Have you read the Getting Started section thoroughly?

    • ✅ Yes

  • How did you add yourself as a contributor?

  • Have you run npm run contributors:generate to generate your profile and the badge on the README?

    • ✅ Yes

Added to documentation?

  • 🙅 no documentation needed

[optional] What GIF best describes this PR or how it makes you feel?

@github-actions GitHub Actions
Copy link

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

@CBID2
Copy link
Contributor

CBID2 commented Nov 14, 2023

Hi @Bradondev. Can you fill out the checkboxes in your PR form? It'll help me and the other maintainers see how we can best review your contribution.

adiati98
adiati98 requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@adiati98 adiati98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Bradondev,
Thank you for your PR! 🙌

Adding to the suggestion from @CBID2:

You missed one step here (step 6).
Please generate your profile on the README by running the npm run contributors:generate.

Let us know when it's fixed and ready for a review.
Thank you. 🙂

@github-actions GitHub Actions
Copy link

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

5 similar comments
@github-actions GitHub Actions
Copy link

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

@github-actions GitHub Actions
Copy link

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

@github-actions GitHub Actions
Copy link

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

@github-actions GitHub Actions
Copy link

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

@github-actions GitHub Actions
Copy link

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

@CBID2
Copy link
Contributor

CBID2 commented Nov 14, 2023

To add to my original comment @Bradondev, we've merged in some new PRs, so can you merge the latest changes and resolve conflicts? If you need some help with that, check out this post: Keeping Your Branch Up to Date and Handling Merge Conflicts While Waiting for PR Reviews.

@CBID2 CBID2 enabled auto-merge November 14, 2023 21:00
@Bradondev
Copy link
Contributor Author

Okay, will do that thanks for the help.

@CBID2
Copy link
Contributor

CBID2 commented Nov 15, 2023

Okay, will do that thanks for the help.

You're welcome! You can also check out this section in the README

auto-merge was automatically disabled November 15, 2023 00:31

Head branch was pushed to by a user without write access

@github-actions GitHub Actions
Copy link

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

@github-actions GitHub Actions
Copy link

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

@CBID2
Copy link
Contributor

CBID2 commented Nov 29, 2023

Hey @Bradondev. I fixed the merge conflicts. Don't forget to do npm run contributors:generate in your terminal.

@BekahHW BekahHW mentioned this pull request Dec 1, 2023
Closed
2 tasks
@CBID2 CBID2 enabled auto-merge December 11, 2023 18:34
@github-actions GitHub Actions
Copy link

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

@CBID2
Copy link
Contributor

CBID2 commented Dec 11, 2023

Hi @Bradondev! :) Are you going to work on this? :)

@github-actions GitHub Actions
Copy link

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

@github-actions GitHub Actions
Copy link

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

@github-actions GitHub Actions
Copy link

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

@github-actions GitHub Actions
Copy link

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

CBID2
CBID2 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Bradondev! :) To move the merge process forward, I resolved your merge conflicts, generated the command. In the future, I highly recommend resolving your merge conflicts promptly. It'll make it easier for maintainers to review your contributions. Speaking of other projects and contributions, check out our pizza-verse repo join our Discord server to get updates on OpenSauced and to see what other people are working on: https://discord.com/invite/U2peSNf23P

@CBID2 CBID2 merged commit 5dcea1a into open-sauced:main Dec 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiati98 adiati98 adiati98 approved these changes

@CBID2 CBID2 CBID2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bradondev @CBID2 @adiati98