Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct dockerhub secrets location #322

Merged
merged 2 commits into from
Nov 21, 2024
Merged

correct dockerhub secrets location #322

merged 2 commits into from
Nov 21, 2024

Conversation

baentsch
Copy link
Member

@baentsch baentsch commented Nov 21, 2024

@Hayyaaf does this change look reasonable to you?

Edit/add: I took it from

-
name: Login to Docker Hub
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
where it seems to work...

Signed-off-by: Michael Baentsch <[email protected]>
@Hawazyn
Copy link
Contributor

Hawazyn commented Nov 21, 2024

Hi @baentsch, looks good to me. Thanks for addressing this.

Signed-off-by: Michael Baentsch <[email protected]>
@baentsch baentsch mentioned this pull request Nov 21, 2024
17 tasks
@baentsch baentsch merged commit c0ab933 into main Nov 21, 2024
10 of 13 checks passed
@baentsch
Copy link
Member Author

CI failures due to exceeding runtime, not logical flaws.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants